[ANN] LuaRocks 3.0.0-rc1

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[ANN] LuaRocks 3.0.0-rc1

Hisham
Hello list,

This is the announcement of the release candidate for LuaRocks 3.0.0.
If no critical show-stopper bugs are reported, this same packages will
be renamed as 3.0.0 final, with a proper release announcement.

The packages are here:

https://luarocks.github.io/luarocks/releases/

** New in this rc1: Windows packages **
This release contains both the Unix tarball and two versions of the
Windows zip: the "legacy" installer which works the same as the zip
files released with all LuaRocks versions so far, and a new zip file
with the all-in-one luarocks.exe binary that runs with no additional
dependencies. The luarocks.exe program assumes you're using a
Microsoft compiler toolchain when running from the Visual Studio
developer console, or a mingw toolchain otherwise (everything can be
hand-tuned via config files as usual).

If you give this rc1 a spin, please let me know! The more positive
feedback it gets ("no, it did not set my computer on fire!"), the
faster this package will graduate into 3.0.0 final. :)

-- Hisham

Reply | Threaded
Open this post in threaded view
|

Re: [ANN] LuaRocks 3.0.0-rc1

François Perrad


2018-07-19 19:52 GMT+02:00 Hisham <[hidden email]>:
Hello list,

This is the announcement of the release candidate for LuaRocks 3.0.0.
If no critical show-stopper bugs are reported, this same packages will
be renamed as 3.0.0 final, with a proper release announcement.

The packages are here:

https://luarocks.github.io/luarocks/releases/

** New in this rc1: Windows packages **
This release contains both the Unix tarball and two versions of the
Windows zip: the "legacy" installer which works the same as the zip
files released with all LuaRocks versions so far, and a new zip file
with the all-in-one luarocks.exe binary that runs with no additional
dependencies. The luarocks.exe program assumes you're using a
Microsoft compiler toolchain when running from the Visual Studio
developer console, or a mingw toolchain otherwise (everything can be
hand-tuned via config files as usual).

If you give this rc1 a spin, please let me know! The more positive
feedback it gets ("no, it did not set my computer on fire!"), the
faster this package will graduate into 3.0.0 final. :)



With Buildroot, rocks are properly built.
But the command `unpack` produces many warnings `touch: invalid date format`.
See below, a full log with lpeg-1.0.1-1.

François

>>> lpeg 1.0.1-1 Extracting
mkdir -p /home/user/build/qarm/build/lpeg-1.0.1-1/luarocks-extract
cd /home/user/build/qarm/build/lpeg-1.0.1-1/luarocks-extract && LUA_PATH="/home/user/build/qarm/host/share/lua/5.3/?.lua" /home/user/build/qarm/host/bin/lua /home/user/build/qarm/host/bin/luarocks unpack --force /home/user/checkout/download/lpeg/lpeg-1.0.1-1.src.rock
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'
touch: invalid date format '20170114195716'

Done. You may now enter directory
lpeg-1.0.1-1/lpeg-1.0.1
and type 'luarocks make' to build.

 
-- Hisham


Reply | Threaded
Open this post in threaded view
|

Re: [ANN] LuaRocks 3.0.0-rc1

Hisham
On 19 July 2018 at 16:24, François Perrad <[hidden email]> wrote:

>
>
> 2018-07-19 19:52 GMT+02:00 Hisham <[hidden email]>:
>>
>> Hello list,
>>
>> This is the announcement of the release candidate for LuaRocks 3.0.0.
>> If no critical show-stopper bugs are reported, this same packages will
>> be renamed as 3.0.0 final, with a proper release announcement.
>>
>> The packages are here:
>>
>> https://luarocks.github.io/luarocks/releases/
>>
>> ** New in this rc1: Windows packages **
>> This release contains both the Unix tarball and two versions of the
>> Windows zip: the "legacy" installer which works the same as the zip
>> files released with all LuaRocks versions so far, and a new zip file
>> with the all-in-one luarocks.exe binary that runs with no additional
>> dependencies. The luarocks.exe program assumes you're using a
>> Microsoft compiler toolchain when running from the Visual Studio
>> developer console, or a mingw toolchain otherwise (everything can be
>> hand-tuned via config files as usual).
>>
>> If you give this rc1 a spin, please let me know! The more positive
>> feedback it gets ("no, it did not set my computer on fire!"), the
>> faster this package will graduate into 3.0.0 final. :)
>>
>
>
> With Buildroot, rocks are properly built.
> But the command `unpack` produces many warnings `touch: invalid date
> format`.
> See below, a full log with lpeg-1.0.1-1.

Thank you for testing, François!

Does the following patch fix it?

Thanks!
-- Hisham

diff --git a/src/luarocks/fs/unix/tools.lua b/src/luarocks/fs/unix/tools.lua
index d6277119..cf49ee46 100644
--- a/src/luarocks/fs/unix/tools.lua
+++ b/src/luarocks/fs/unix/tools.lua
@@ -255,7 +255,7 @@ function tools.set_time(file, time)
       time = os.date("*t", time)
    end
    if type(time) == "table" then
-      flag = ("-t %04d%02d%02d%02d%02d%02d"):format(time.year,
time.month, time.day, time.hour, time.min, time.sec)
+      flag = ("-t %04d%02d%02d%02d%02d%.%02d"):format(time.year,
time.month, time.day, time.hour, time.min, time.sec)
    end
    return fs.execute(vars.TOUCH .. " " .. flag, file)
 end

Reply | Threaded
Open this post in threaded view
|

Re: [ANN] LuaRocks 3.0.0-rc1

Hisham
On 19 July 2018 at 16:30, Hisham <[hidden email]> wrote:
> Does the following patch fix it?

Or rather, adding a single dot:

diff --git a/src/luarocks/fs/unix/tools.lua b/src/luarocks/fs/unix/tools.lua
index d6277119..cf49ee46 100644
--- a/src/luarocks/fs/unix/tools.lua
+++ b/src/luarocks/fs/unix/tools.lua
@@ -255,7 +255,7 @@ function tools.set_time(file, time)
       time = os.date("*t", time)
    end
    if type(time) == "table" then
-      flag = ("-t %04d%02d%02d%02d%02d%02d"):format(time.year,
time.month, time.day, time.hour, time.min, time.sec)
+      flag = ("-t %04d%02d%02d%02d%02d.%02d"):format(time.year,
time.month, time.day, time.hour, time.min, time.sec)
    end
    return fs.execute(vars.TOUCH .. " " .. flag, file)
 end

Reply | Threaded
Open this post in threaded view
|

Re: [ANN] LuaRocks 3.0.0-rc1

François Perrad


2018-07-19 21:37 GMT+02:00 Hisham <[hidden email]>:
On 19 July 2018 at 16:30, Hisham <[hidden email]> wrote:
> Does the following patch fix it?

Or rather, adding a single dot:



This second patch fixes the issue.

François

 
diff --git a/src/luarocks/fs/unix/tools.lua b/src/luarocks/fs/unix/tools.lua
index d6277119..cf49ee46 100644
--- a/src/luarocks/fs/unix/tools.lua
+++ b/src/luarocks/fs/unix/tools.lua
@@ -255,7 +255,7 @@ function tools.set_time(file, time)
       time = os.date("*t", time)
    end
    if type(time) == "table" then
-      flag = ("-t %04d%02d%02d%02d%02d%02d"):format(time.year,
time.month, time.day, time.hour, time.min, time.sec)
+      flag = ("-t %04d%02d%02d%02d%02d.%02d"):format(time.year,
time.month, time.day, time.hour, time.min, time.sec)
    end
    return fs.execute(vars.TOUCH .. " " .. flag, file)
 end